fix: Fixed the inconsistency in the handling of AAD openIdIssuer #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance we can merge this please. :) |
|
Hi reviewers, @Timothyw0 and @cjk7989 , is it possible to have PR merged so we can get a working AAD local auth? Thank you for considering @shibayan's contribution! |
|
Just wasted half a day trying to figure out why my AAD auth wasn't working when deployed, because I'd used the issuer string necessary to make the emulator work. Why hasn't this fix been reviewed/merged? Is the SWA CLI no longer being developed? |
|
+1 also having this issue! Will this fix ever be deployed?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value specified for
openIdIssuerwhen using AAD was different from the value required by SWA, causing an inconsistency. This is fixed by constructing the URL based on the tenant ID.Fixes #928